Differential D10274

Use `file.download` to retrieve macro images in the IRC macro bot
ClosedPublic
Actions

Authored by epriestley on Aug 15 2014, 3:37 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T5884: Existing files not set to CDNable

Commits

Restricted Diffusion Commit
rPf9de495d0bc3: Use `file.download` to retrieve macro images in the IRC macro bot

Summary

Fixes T5884. Macro images are no longer public on most installs. We could generate tokens for them, but this (using Conduit to pull the file data) is easier and more correct.

Test Plan

Logged a bot into IRC and had it spam part of a macro before being killed for flooding.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24741.Aug 15 2014, 3:37 PM

epriestley retitled this revision from to Use `file.download` to retrieve macro images in the IRC macro bot.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5884: Existing files not set to CDNable.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 15 2014, 3:37 PM

Harbormaster completed remote builds in B2240: Diff 24741.Aug 15 2014, 3:38 PM

btrahan accepted this revision.Aug 15 2014, 5:24 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 15 2014, 5:24 PM

Closed by commit rPf9de495d0bc3 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

conduit/

MacroQueryConduitAPIMethod.php

3 lines

infrastructure/

daemon/

bot/

handler/

PhabricatorBotMacroHandler.php

12 lines

Diff 24755

View Options

src/applications/macro/conduit/MacroQueryConduitAPIMethod.php