Page MenuHomePhabricator

Fix `cancdn` vs `canCDN` flag
ClosedPublic

Authored by epriestley on Aug 14 2014, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 11:14 PM
Unknown Object (File)
Tue, Dec 3, 9:01 PM
Unknown Object (File)
Sun, Dec 1, 2:39 PM
Unknown Object (File)
Wed, Nov 27, 6:06 PM
Unknown Object (File)
Wed, Nov 27, 1:26 PM
Unknown Object (File)
Tue, Nov 19, 4:03 PM
Unknown Object (File)
Oct 15 2024, 12:53 PM
Unknown Object (File)
Oct 14 2024, 12:02 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
T5884: Existing files not set to CDNable
Commits
Restricted Diffusion Commit
rPae1a821b658a: Fix `cancdn` vs `canCDN` flag
Summary

Ref T5884. We migrated to add a canCDN flag, but the code looks for a cancdn flag.

If this fixes the issue, I'll migrate cancdn to canCDN in the next diff.

Test Plan

Viewed some files, including old files, and saw the cacheability I expected.

Diff Detail

Repository
rP Phabricator
Branch
cancdncase1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/files/storage/PhabricatorFile.php:852XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 2224
Build 2228: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix `cancdn` vs `canCDN` flag.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 14 2014, 6:49 PM
epriestley updated this revision to Diff 24718.

Closed by commit rPae1a821b658a (authored by @epriestley).