Differential D10261

Make Notification menu abs positioned
ClosedPublic
Actions

Authored by chad on Aug 13 2014, 10:35 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5537: Notification panel does not resize itself to browser window height

Commits

Restricted Diffusion Commit
rPc740d554f667: Make Notification menu abs positioned

Summary

Fixes T5537. Makes it so I can scroll and see the bottom of notifications.

Test Plan

Open Notification Menu. Scroll. No longer follows me.

Diff Detail

Repository

rP Phabricator

Branch

position-abs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2218
Build 2222: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 24702.Aug 13 2014, 10:35 PM

chad retitled this revision from to Make Notification menu abs positioned.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T5537: Notification panel does not resize itself to browser window height.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 13 2014, 10:35 PM

Harbormaster completed remote builds in B2218: Diff 24702.Aug 13 2014, 10:36 PM

epriestley accepted this revision.Aug 13 2014, 10:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 13 2014, 10:36 PM

Closed by commit rPc740d554f667 (authored by @chad).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

application/

base/

notification-menu.css

2 lines

Diff 24702

View Options

resources/celerity/map.php