Paths

Table of Contentst

Make arcanist lint tests flexible about testcase formatting
ClosedPublic
Actions

Authored by epriestley on Aug 13 2014, 2:26 AM.

Details

Reviewers

thoughtpolice
btrahan

Commits

rARCe9c80de73cf0: Make arcanist lint tests flexible about testcase formatting

Summary

We currently require an exact number of "~" characters, but this is needless and error-prone.

Instead, allow any number larger than 3.

Test Plan

Added meta test-case.
Ran arc unit --everything.

Diff Detail

Repository

rARC Arcanist

Branch

flexible

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2199
Build 2203: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24667.Aug 13 2014, 2:26 AM

epriestley retitled this revision from to Make arcanist lint tests flexible about testcase formatting.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: thoughtpolice, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 13 2014, 2:26 AM

Harbormaster completed remote builds in B2199: Diff 24667.Aug 13 2014, 2:27 AM

itsawesome

This revision is now accepted and ready to land.Aug 13 2014, 2:31 AM

Closed by commit rARCe9c80de73cf0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

ArcanistLinterTestCase.php

2 lines

text/

variable-dividers.lint-test

3 lines

Diff 24667

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

View Options

src/lint/linter/tests/text/variable-dividers.lint-test

Make arcanist lint tests flexible about testcase formattingClosedPublicActions