Page MenuHomePhabricator
Differential D10250

[lint] Add HLint-based Haskell linter
ClosedPublic
Actions

Authored by thoughtpolice on Aug 13 2014, 2:17 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Dec 13, 7:44 PM
Unknown Object (File)
Thu, Dec 12, 10:19 PM
Unknown Object (File)
Sat, Dec 7, 10:13 AM
Unknown Object (File)
Thu, Dec 5, 5:03 PM
Unknown Object (File)
Wed, Dec 4, 12:28 AM
Unknown Object (File)
Wed, Nov 27, 4:48 AM
Unknown Object (File)
Nov 22 2024, 11:40 PM
Unknown Object (File)
Nov 19 2024, 2:53 PM
View All Files
Subscribers
epriestley
Korvin
thoughtpolice_

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC4c0edd296e33: [lint] Add HLint-based Haskell linter
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

This adds a lint engine for hlint, which is the standard and most general Haskell lint tool around these days.

Signed-off-by: Austin Seipp <aseipp@pobox.com>

Test Plan

Install hlint, and run arc unit.

Diff Detail

Repository
rARC Arcanist
Branch
hlint
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2197
Build 2201: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

thoughtpolice updated this revision to Diff 24664.Aug 13 2014, 2:17 AM
thoughtpolice retitled this revision from to [lint] Add HLint-based Haskell linter.
thoughtpolice updated this object.
thoughtpolice edited the test plan for this revision. (Show Details)
thoughtpolice added reviewers: Blessed Reviewers, epriestley.
Herald edited edge metadata. · View Herald TranscriptAug 13 2014, 2:17 AM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2196: Diff 24664.Aug 13 2014, 2:18 AM
thoughtpolice updated this revision to Diff 24665.Aug 13 2014, 2:25 AM
thoughtpolice edited edge metadata.

Fix unit tests thanks to Evan (too many "~" characters, lololol)

thoughtpolice updated this object.Aug 13 2014, 2:26 AM
thoughtpolice edited the test plan for this revision. (Show Details)
thoughtpolice added a project: Arcanist.
Harbormaster completed remote builds in B2197: Diff 24665.Aug 13 2014, 2:26 AM
epriestley requested changes to this revision.Aug 13 2014, 2:40 AM
epriestley edited edge metadata.

One minor thing -- since messages get shipped around, they should just be text.

src/lint/linter/ArcanistHLintLinter.php
73

Unused?

84–85

woah

84–89

These messages get uploaded to the web too, so you probably should avoid console formatting.

This revision now requires changes to proceed.Aug 13 2014, 2:40 AM
thoughtpolice added inline comments.Aug 13 2014, 2:42 AM
src/lint/linter/ArcanistHLintLinter.php
73

Yep.

84–85

I was rather surprised by this behavior too, believe it or not.

84–89

OK, I'll see what else I can cook up.

thoughtpolice updated this revision to Diff 24675.Aug 13 2014, 2:46 AM
thoughtpolice edited edge metadata.
  • Remove console formatting from diff
  • Kill unused variable
Harbormaster completed remote builds in B2204: Diff 24675.Aug 13 2014, 2:47 AM
epriestley accepted this revision.Aug 13 2014, 2:48 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 13 2014, 2:48 AM
epriestley closed this revision.Aug 13 2014, 2:49 AM
epriestley updated this revision to Diff 24676.
epriestley added a subscriber: thoughtpolice_.

Closed by commit rARC4c0edd296e33 (authored by @thoughtpolice_, committed by @epriestley).

Revision Contents
Changeset List

Diff 24665

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/ArcanistHLintLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistHLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/hlint/01_warn_null.lint-test

Loading...
View Options

src/lint/linter/__tests__/hlint/02_err_eta.lint-test

Loading...
View Options

src/lint/linter/__tests__/hlint/03_no_err.lint-test

Loading...
Phabricator · Built by Phacility