Page MenuHomePhabricator

[lint] Add HLint-based Haskell linter
ClosedPublic

Authored by thoughtpolice on Aug 13 2014, 2:17 AM.
Referenced Files
F15406393: D10250.diff
Tue, Mar 18, 12:29 PM
F15400375: D10250.id24676.diff
Mon, Mar 17, 11:18 AM
F15395720: D10250.diff
Sun, Mar 16, 9:15 AM
F15380786: D10250.id24665.diff
Fri, Mar 14, 4:27 AM
F15283695: D10250.diff
Tue, Mar 4, 8:18 AM
Unknown Object (File)
Feb 18 2025, 9:42 AM
Unknown Object (File)
Feb 7 2025, 10:30 PM
Unknown Object (File)
Feb 7 2025, 10:30 PM

Details

Summary

This adds a lint engine for hlint, which is the standard and most general Haskell lint tool around these days.

Signed-off-by: Austin Seipp <aseipp@pobox.com>

Test Plan

Install hlint, and run arc unit.

Diff Detail

Repository
rARC Arcanist
Branch
hlint
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 2196
Build 2200: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestHlintLinter
0 mstestCSSLintLinter
0 mstestCoffeeLintLinter
0 mstestCppcheckLint
0 mstestCpplintLint
View Full Test Results (1 Failed · 23 Passed · 4 Skipped)

Event Timeline

thoughtpolice retitled this revision from to [lint] Add HLint-based Haskell linter.
thoughtpolice updated this object.
thoughtpolice edited the test plan for this revision. (Show Details)
thoughtpolice edited edge metadata.

Fix unit tests thanks to Evan (too many "~" characters, lololol)

thoughtpolice edited the test plan for this revision. (Show Details)
thoughtpolice added a project: Arcanist.
epriestley edited edge metadata.

One minor thing -- since messages get shipped around, they should just be text.

src/lint/linter/ArcanistHLintLinter.php
74

Unused?

85–86

woah

85–90

These messages get uploaded to the web too, so you probably should avoid console formatting.

This revision now requires changes to proceed.Aug 13 2014, 2:40 AM
src/lint/linter/ArcanistHLintLinter.php
74

Yep.

85–86

I was rather surprised by this behavior too, believe it or not.

85–90

OK, I'll see what else I can cook up.

thoughtpolice edited edge metadata.
  • Remove console formatting from diff
  • Kill unused variable
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 13 2014, 2:48 AM
epriestley updated this revision to Diff 24676.
epriestley added a subscriber: thoughtpolice_.

Closed by commit rARC4c0edd296e33 (authored by @thoughtpolice_, committed by @epriestley).