Page MenuHomePhabricator
Differential D10237

Add a setting to disable all notification email
ClosedPublic
Actions

Authored by epriestley on Aug 12 2014, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 6:53 AM
Unknown Object (File)
Thu, Dec 12, 7:48 AM
Unknown Object (File)
Sun, Dec 8, 2:12 AM
Unknown Object (File)
Wed, Dec 4, 6:25 AM
Unknown Object (File)
Tue, Dec 3, 3:46 AM
Unknown Object (File)
Sat, Nov 30, 7:30 AM
Unknown Object (File)
Fri, Nov 29, 10:24 PM
Unknown Object (File)
Fri, Nov 29, 10:20 PM
View All Files
Subscribers
• chasemp
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5861: Improve the power of email settings
Commits
Restricted Diffusion Commit
rPd011f8fdc6c4: Add a setting to disable all notification email
Summary

Ref T5861. Adds an option to opt out of all notification email. We'll still send you password resets, email verifications, etc.

Test Plan

Screen_Shot_2014-08-12_at_10.25.05_AM.png (652×1 px, 151 KB)

  • Added unit tests.
  • With preference set to different things, tried to send myself mail. Mail respected preferences.
  • Sent password reset email, which got through the preference.

Diff Detail

Repository
rP Phabricator
Branch
mail2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2176
Build 2180: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24630.Aug 12 2014, 5:27 PM
epriestley retitled this revision from to Add a setting to disable all notification email.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T5861: Improve the power of email settings.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 12 2014, 5:27 PM
Harbormaster completed remote builds in B2176: Diff 24630.Aug 12 2014, 5:28 PM
chad accepted this revision.Aug 12 2014, 5:34 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 12 2014, 5:34 PM
• chasemp added a subscriber: • chasemp.Aug 12 2014, 6:05 PM
epriestley closed this revision.Aug 12 2014, 7:28 PM
epriestley updated this revision to Diff 24641.

Closed by commit rPd011f8fdc6c4 (authored by @epriestley).

Revision Contents
Changeset List

Diff 24630

View Options

src/applications/auth/controller/PhabricatorEmailLoginController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

Loading...
View Options

src/applications/metamta/storage/__tests__/PhabricatorMetaMTAMailTestCase.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleApproveController.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/applications/people/storage/PhabricatorUserEmail.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
Phabricator · Built by Phacility