Page MenuHomePhabricator
Differential D10233

Publish stories about objects in projects as related to projects
ClosedPublic
Actions

Authored by epriestley on Aug 12 2014, 12:09 PM.
Tags
None
Referenced Files
F14408543: D10233.diff
Tue, Dec 24, 4:52 AM
F14406919: D10233.id24622.diff
Mon, Dec 23, 10:52 PM
Unknown Object (File)
Mon, Dec 2, 10:06 AM
Unknown Object (File)
Wed, Nov 27, 1:31 PM
Unknown Object (File)
Wed, Nov 27, 4:33 AM
Unknown Object (File)
Tue, Nov 26, 7:34 AM
Unknown Object (File)
Mon, Nov 25, 10:40 AM
Unknown Object (File)
Nov 23 2024, 1:48 AM
View All Files
Subscribers
epriestley
timor

Details

Reviewers
btrahan
Maniphest Tasks
T5456: Built-in Feed Query "Projects" does not display all relevant objects
Commits
Restricted Diffusion Commit
rPc9835c4492db: Publish stories about objects in projects as related to projects
Summary

Fixes T5456. We lost this logic in the transition to applicationtransactions.

When publishing a feed story, mark all of the object's projects as related, so the project filter in feed works.

Test Plan

Made a comment on a task associated with a project, saw the story in filtered feed.

Diff Detail

Repository
rP Phabricator
Branch
projfeed
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2171
Build 2175: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24622.Aug 12 2014, 12:09 PM
epriestley retitled this revision from to Publish stories about objects in projects as related to projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5456: Built-in Feed Query "Projects" does not display all relevant objects.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 12 2014, 12:09 PM
epriestley updated this revision to Diff 24623.Aug 12 2014, 12:10 PM
  • Remove debugging code.
Harbormaster completed remote builds in B2170: Diff 24622.Aug 12 2014, 12:10 PM
Harbormaster completed remote builds in B2171: Diff 24623.
timor added a subscriber: timor.Aug 12 2014, 2:16 PM
btrahan accepted this revision.Aug 12 2014, 7:13 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 12 2014, 7:13 PM
epriestley closed this revision.Aug 12 2014, 7:27 PM
epriestley updated this revision to Diff 24638.

Closed by commit rPc9835c4492db (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
13 lines

Diff 24623

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility