Page MenuHomePhabricator
Differential D10233

Publish stories about objects in projects as related to projects
ClosedPublic
Actions

Authored by epriestley on Aug 12 2014, 12:09 PM.
Tags
None
Referenced Files
F14067743: D10233.diff
Tue, Nov 19, 4:35 PM
F14066081: D10233.diff
Tue, Nov 19, 8:05 AM
F14047701: D10233.id24638.diff
Thu, Nov 14, 4:57 AM
F14037221: D10233.id24622.diff
Sun, Nov 10, 2:26 PM
F14029117: D10233.id24622.diff
Fri, Nov 8, 7:39 PM
F13998409: D10233.diff
Thu, Oct 24, 9:21 AM
F13963071: D10233.id24638.diff
Oct 15 2024, 1:50 PM
Unknown Object (File)
Oct 12 2024, 12:17 PM
View All Files
Subscribers
epriestley
timor

Details

Reviewers
btrahan
Maniphest Tasks
T5456: Built-in Feed Query "Projects" does not display all relevant objects
Commits
Restricted Diffusion Commit
rPc9835c4492db: Publish stories about objects in projects as related to projects
Summary

Fixes T5456. We lost this logic in the transition to applicationtransactions.

When publishing a feed story, mark all of the object's projects as related, so the project filter in feed works.

Test Plan

Made a comment on a task associated with a project, saw the story in filtered feed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24622.Aug 12 2014, 12:09 PM
epriestley retitled this revision from to Publish stories about objects in projects as related to projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5456: Built-in Feed Query "Projects" does not display all relevant objects.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 12 2014, 12:09 PM
epriestley updated this revision to Diff 24623.Aug 12 2014, 12:10 PM
  • Remove debugging code.
Harbormaster completed remote builds in B2170: Diff 24622.Aug 12 2014, 12:10 PM
Harbormaster completed remote builds in B2171: Diff 24623.
timor added a subscriber: timor.Aug 12 2014, 2:16 PM
btrahan accepted this revision.Aug 12 2014, 7:13 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 12 2014, 7:13 PM
epriestley closed this revision.Aug 12 2014, 7:27 PM
epriestley updated this revision to Diff 24638.

Closed by commit rPc9835c4492db (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
13 lines

Diff 24638

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility