Hello?

This will take a long time for me to review, so I probably won't get to it for a while.

I need to convince myself this is the best approach before I accept this. To do that, I need to research the answers to a lot of questions that I'm not very familiar with (like "Why doesn't node install binaries on Windows?"), reproduce the issue, etc.

I need to convince myself this is the best approach before I accept this. To do that, I need to research the answers to a lot of questions that I'm not very familiar with (like "Why doesn't node install binaries on Windows?"), reproduce the issue, etc.

I mean, I just used the existing ArcanistExternalLinters facilities (the interpreter related parts) that said I understand your concerns. The reason is Windows not supporting shebangs, otherwise it has the "binaries" but you cannot run ./node_modules/jshint/bin/jshint directly for instance because it doesn't have a file extension, thus doesn't have an associated program to run it (node) and Windows does not support doing this automatically with the help of shebangs.

On some occasions you may have .cmd files which can be directly run from the command line by typing just the name (without the extension) but when you try to run it programmatically, you need to provide the full path, thus the .cmd part too which differs from Unix-like systems so I'd say the safest and most compatible approach is the current "separate interpreter/binary" approach.

You are of course free to do your own research and validate what I said above :)