Page MenuHomePhabricator

Consolidate handling of special properties for newly uploaded files
ClosedPublic

Authored by epriestley on Aug 11 2014, 3:41 PM.
Tags
None
Referenced Files
F14015910: D10216.id24586.diff
Mon, Nov 4, 2:39 AM
F14015909: D10216.id24579.diff
Mon, Nov 4, 2:39 AM
F14002649: D10216.diff
Fri, Oct 25, 8:56 PM
F13977565: D10216.id24586.diff
Oct 18 2024, 7:10 PM
Unknown Object (File)
Oct 1 2024, 8:20 AM
Unknown Object (File)
Sep 17 2024, 7:24 AM
Unknown Object (File)
Sep 14 2024, 11:18 AM
Unknown Object (File)
Sep 14 2024, 11:17 AM
Subscribers

Details

Summary

Fixes T5849. When a new file is created, we might have to actually write the data to a storage engine, or we might be able to just point at data which is already there.

Currently, these two paths handle $params with different code and mild behavioral differences. Instead, have them call the same code so they get the same behavior.

Test Plan
  • Uploaded the same file multiple times to home page.
  • Uploaded the same file multiple times as profile picture.
  • Generated files via Diffusion.
  • All the files got the expected properties, whether they were reusing data or not.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Consolidate handling of special properties for newly uploaded files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: 20after4, btrahan.
20after4 edited edge metadata.

This looks good, and a lot cleaner.

This revision is now accepted and ready to land.Aug 11 2014, 4:29 PM
epriestley updated this revision to Diff 24586.

Closed by commit rPeb9dcd6fbaf5 (authored by @epriestley).