Page MenuHomePhabricator

Rename Lisk internal getProperties() methods to avoid collisions
ClosedPublic

Authored by epriestley on Aug 11 2014, 12:31 PM.
Tags
None
Referenced Files
F15460892: D10210.id24572.diff
Tue, Apr 1, 3:13 AM
F15428332: D10210.id24572.diff
Sun, Mar 23, 7:40 PM
F15395440: D10210.id24596.diff
Sun, Mar 16, 7:01 AM
F15388820: D10210.id24572.diff
Sat, Mar 15, 4:27 AM
F15387032: D10210.id.diff
Sat, Mar 15, 1:41 AM
F15384453: D10210.id24596.diff
Fri, Mar 14, 7:57 PM
Unknown Object (File)
Mar 3 2025, 4:27 PM
Unknown Object (File)
Mar 3 2025, 4:01 PM
Subscribers

Details

Summary

See some discussion here:

https://github.com/phacility/phabricator/commit/24a6eeb8d8a52b592e456d110934670d4ace9b31#commitcomment-7334892

The protected $properties; storage parameter added to ProjectColumn is shadowed by getProperties() in the base class.

Although this works correctly for me, it's ambiguous and worth fixing. Make the base class methods explicit.

Test Plan

Used grep to find callers for both methods and renamed them.

Diff Detail

Repository
rP Phabricator
Branch
boards1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2142
Build 2146: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Rename Lisk internal getProperties() methods to avoid collisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2014, 6:27 PM
epriestley updated this revision to Diff 24596.

Closed by commit rP448020a57351 (authored by @epriestley).