Page MenuHomePhabricator

Rename Lisk internal getProperties() methods to avoid collisions
ClosedPublic

Authored by epriestley on Aug 11 2014, 12:31 PM.
Tags
None
Referenced Files
F14028088: D10210.diff
Fri, Nov 8, 11:47 AM
F13995597: D10210.id.diff
Wed, Oct 23, 2:07 PM
F13989641: D10210.diff
Mon, Oct 21, 9:57 PM
F13978168: D10210.id.diff
Fri, Oct 18, 9:53 PM
Unknown Object (File)
Fri, Oct 11, 12:40 PM
Unknown Object (File)
Oct 10 2024, 7:03 AM
Unknown Object (File)
Sep 19 2024, 7:15 PM
Unknown Object (File)
Sep 17 2024, 10:15 PM
Subscribers

Details

Summary

See some discussion here:

https://github.com/phacility/phabricator/commit/24a6eeb8d8a52b592e456d110934670d4ace9b31#commitcomment-7334892

The protected $properties; storage parameter added to ProjectColumn is shadowed by getProperties() in the base class.

Although this works correctly for me, it's ambiguous and worth fixing. Make the base class methods explicit.

Test Plan

Used grep to find callers for both methods and renamed them.

Diff Detail

Repository
rP Phabricator
Branch
boards1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2142
Build 2146: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Rename Lisk internal getProperties() methods to avoid collisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2014, 6:27 PM
epriestley updated this revision to Diff 24596.

Closed by commit rP448020a57351 (authored by @epriestley).