Differential D10193

allow phids other than users (i.e. mailinglists)
ClosedPublic
Actions

Authored by • chasemp on Aug 8 2014, 4:52 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP57eb3aecb68f: allow phids other than users (i.e. mailinglists)

Summary

Via the UI adding a mailinglist for CC works, but via
the API currently it shows:

One or more PHIDs were invalid for ccPHIDS

This removes the user validation check for ccPHIDs.

(I left it in for other things like owner since that seems
still appropriate?)

Test Plan

used arc locally to add a mailinglist to cc

echo '{"id": 2, "ccPHIDs": ["PHID-MLST-ohduchbv4dfimk7opt3r"]}' | arc call-conduit maniphest.update

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

• chasemp updated this revision to Diff 24520.Aug 8 2014, 4:52 PM

• chasemp retitled this revision from to allow phids other than users (i.e. mailinglists).

• chasemp updated this object.

• chasemp edited the test plan for this revision. (Show Details)

• chasemp added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 8 2014, 4:52 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2109: Diff 24520.Aug 8 2014, 4:53 PM

epriestley accepted this revision.Aug 8 2014, 4:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 8 2014, 4:53 PM

Closed by commit rP57eb3aecb68f (authored by cpettet <rush@wikimedia.org>, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

conduit/

ManiphestConduitAPIMethod.php

4 lines

Diff 24521

View Options

src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php

allow phids other than users (i.e. mailinglists)ClosedPublicActions