Page MenuHomePhabricator

allow phids other than users (i.e. mailinglists)
ClosedPublic

Authored by chasemp on Aug 8 2014, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 12:57 AM
Unknown Object (File)
Fri, Dec 20, 6:03 AM
Unknown Object (File)
Fri, Dec 20, 4:04 AM
Unknown Object (File)
Thu, Dec 19, 10:45 AM
Unknown Object (File)
Thu, Dec 19, 10:45 AM
Unknown Object (File)
Thu, Dec 19, 10:45 AM
Unknown Object (File)
Thu, Dec 12, 4:10 PM
Unknown Object (File)
Thu, Dec 12, 4:10 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP57eb3aecb68f: allow phids other than users (i.e. mailinglists)
Summary

Via the UI adding a mailinglist for CC works, but via
the API currently it shows:

One or more PHIDs were invalid for ccPHIDS

This removes the user validation check for ccPHIDs.

(I left it in for other things like owner since that seems
still appropriate?)

Test Plan

used arc locally to add a mailinglist to cc

echo '{"id": 2, "ccPHIDs": ["PHID-MLST-ohduchbv4dfimk7opt3r"]}' | arc call-conduit maniphest.update

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chasemp retitled this revision from to allow phids other than users (i.e. mailinglists).
chasemp updated this object.
chasemp edited the test plan for this revision. (Show Details)
chasemp added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 8 2014, 4:53 PM
epriestley updated this revision to Diff 24521.

Closed by commit rP57eb3aecb68f (authored by cpettet <rush@wikimedia.org>, committed by @epriestley).