Fix Phrequent duration accounting
ClosedPublic
Actions

Authored by epriestley on Aug 7 2014, 10:51 PM.

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T5705: "Time spent" in Phrequent is incorrect

Commits

Restricted Diffusion Commit
rPc0585b7a34ed: Fix Phrequent duration accounting

Summary

Fixes T5705. This was just derp; instead of returning the duration of the first slice, return the duration of all the slices.

Test Plan

Added unit tests. Saw reasonable results in the UI.

Diff Detail

Repository

rP Phabricator

Branch

phreqtime

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2095
Build 2099: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24499.Aug 7 2014, 10:51 PM

epriestley retitled this revision from to Fix Phrequent duration accounting.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: hach-que, btrahan.

epriestley added a task: T5705: "Time spent" in Phrequent is incorrect.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 7 2014, 10:51 PM

Harbormaster completed remote builds in B2095: Diff 24499.Aug 7 2014, 10:52 PM

Quite derp indeed.

I'm going to go ahead and assume that this doesn't impact (or also fixes issues we didn't notice) with the Arcanist commands.

This revision is now accepted and ready to land.Aug 8 2014, 12:00 AM

Closed by commit rPc0585b7a34ed (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phrequent/

storage/

PhrequentTimeSlices.php

6 lines

__tests__/

PhrequentTimeBlockTestCase.php

24 lines

Diff 24499

View Options

src/applications/phrequent/storage/PhrequentTimeSlices.php

View Options

src/applications/phrequent/storage/tests/PhrequentTimeBlockTestCase.php

Fix Phrequent duration accountingClosedPublicActions