Page MenuHomePhabricator
Differential D10144

Normalize project slugs before querying for them
ClosedPublic
Actions

Authored by epriestley on Aug 4 2014, 8:10 PM.
Tags
None
Referenced Files
F14838835: D10144.id.diff
Fri, Jan 31, 6:37 PM
F14837280: D10144.id24407.diff
Fri, Jan 31, 8:02 AM
Unknown Object (File)
Thu, Jan 30, 8:09 AM
Unknown Object (File)
Sat, Jan 25, 8:38 AM
Unknown Object (File)
Sat, Jan 25, 12:10 AM
Unknown Object (File)
Fri, Jan 24, 12:44 AM
Unknown Object (File)
Thu, Jan 23, 2:58 PM
Unknown Object (File)
Thu, Jan 23, 2:58 PM
View All Files
Subscribers
aklapper
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5728: Make /tag/projectname case insensitive
Commits
Restricted Diffusion Commit
rP1e375c97c594: Normalize project slugs before querying for them
Summary

Fixes T5728. In particular:

  • /tag/XYZ/ now works as an alias for /tag/xyz/.
  • arc todo --project ASDF now works as an alias for arc todo --project asdf.
Test Plan

Called project.query and visited /tag/LBHABLHBH/.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24406.Aug 4 2014, 8:10 PM
epriestley retitled this revision from to Normalize project slugs before querying for them.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5728: Make /tag/projectname case insensitive.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 4 2014, 8:10 PM
Harbormaster completed remote builds in B2036: Diff 24406.Aug 4 2014, 8:12 PM
aklapper added a subscriber: aklapper.Aug 4 2014, 9:57 PM
btrahan accepted this revision.Aug 4 2014, 10:49 PM
btrahan edited edge metadata.

nice

This revision is now accepted and ready to land.Aug 4 2014, 10:49 PM
epriestley closed this revision.Aug 4 2014, 11:55 PM
epriestley updated this revision to Diff 24407.

Closed by commit rP1e375c97c594 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
project/
conduit/
3 lines
query/
7 lines

Diff 24407

View Options

src/applications/project/conduit/ProjectQueryConduitAPIMethod.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
Phabricator · Built by Phacility