Page MenuHomePhabricator

Recognize Maniphest task description as a remarkup block
ClosedPublic

Authored by epriestley on Aug 4 2014, 4:21 PM.
Tags
None
Referenced Files
F13158745: D10139.diff
Sun, May 5, 9:18 PM
Unknown Object (File)
Mon, Apr 29, 4:36 PM
Unknown Object (File)
Thu, Apr 25, 1:42 AM
Unknown Object (File)
Fri, Apr 19, 2:06 AM
Unknown Object (File)
Fri, Apr 19, 2:06 AM
Unknown Object (File)
Fri, Apr 19, 2:06 AM
Unknown Object (File)
Thu, Apr 11, 12:59 PM
Unknown Object (File)
Thu, Apr 11, 9:31 AM
Subscribers

Details

Summary

Ref T4589. We don't recognize task descriptions as remarkup blocks, so {F...} references in them do not get attached to the objects, and thus no policy exemption is created.

Recognize them, which activates {F...} and @mentions.

We probably have a few more of these in other applications, but it's not a big deal to clean them up as they arise.

Test Plan

Uploaded a file to a task in the description field, saw it attach and get a policy exemption.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Recognize Maniphest task description as a remarkup block.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2014, 6:52 PM
epriestley updated this revision to Diff 24399.

Closed by commit rP86dbf1d17d20 (authored by @epriestley).