Page MenuHomePhabricator

Apply normal Audit actions directly with Transaction editor
ClosedPublic

Authored by epriestley on Aug 2 2014, 7:29 PM.
Tags
None
Referenced Files
F13320514: D10128.diff
Fri, Jun 14, 5:26 AM
F13309373: D10128.diff
Mon, Jun 10, 10:07 AM
F13307907: D10128.id.diff
Sun, Jun 9, 11:16 PM
F13274399: D10128.diff
Fri, May 31, 3:39 AM
F13260438: D10128.diff
Sun, May 26, 11:54 PM
F13259193: D10128.id24355.diff
Sun, May 26, 5:39 PM
F13244637: D10128.diff
Thu, May 23, 5:12 AM
F13235622: D10128.id.diff
Tue, May 21, 5:57 AM
Subscribers

Details

Summary

Ref T4896. This converts the last "CommentEditor" to a transaction editor and removes a large part of the old code.

Test Plan
  • Added comments.
  • Accepted / added auditors.
  • Added inline comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Apply normal Audit actions directly with Transaction editor.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.

awesometown

src/applications/audit/controller/PhabricatorAuditAddCommentController.php
86–88

surprised this logic isn't a method on commit or something.

This revision is now accepted and ready to land.Aug 2 2014, 9:09 PM
epriestley updated this revision to Diff 24365.

Closed by commit rPb5750412c75b (authored by @epriestley).