Page MenuHomePhabricator
Differential D10123

Use transactions to apply "add auditors" action in Audit
ClosedPublic
Actions

Authored by epriestley on Aug 2 2014, 6:23 PM.
Tags
None
Referenced Files
F13250648: D10123.id24360.diff
Fri, May 24, 3:59 PM
F13245278: D10123.diff
Thu, May 23, 5:54 AM
F13235577: D10123.id24350.diff
Tue, May 21, 5:54 AM
F13235576: D10123.id24360.diff
Tue, May 21, 5:54 AM
F13235575: D10123.id.diff
Tue, May 21, 5:54 AM
F13209298: D10123.id24350.diff
Thu, May 16, 11:11 PM
F13192345: D10123.diff
Sun, May 12, 6:56 AM
Unknown Object (File)
Tue, May 7, 8:13 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T4896: Move Audit to ApplicationTransactions
Commits
Restricted Diffusion Commit
rP688f245a95be: Use transactions to apply "add auditors" action in Audit
Summary

Ref T4896. Move the write for "Add Auditors" inside the new Editor.

There are no longer any readers or writers for metadata, so remove the calls for it.

Test Plan

Added auditors from the web UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24350.Aug 2 2014, 6:23 PM
epriestley retitled this revision from to Use transactions to apply "add auditors" action in Audit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
epriestley added a task: T4896: Move Audit to ApplicationTransactions.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 2 2014, 6:23 PM
Harbormaster completed remote builds in B2005: Diff 24350.Aug 2 2014, 6:24 PM
btrahan accepted this revision.Aug 2 2014, 7:10 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 2 2014, 7:10 PM
epriestley closed this revision.Aug 2 2014, 9:44 PM
epriestley updated this revision to Diff 24360.

Closed by commit rP688f245a95be (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
applications/
audit/
controller/
6 lines
editor/
37 lines
37 lines
mail/
1 line
storage/
38 lines
diffusion/
conduit/
1 line

Diff 24360

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/audit/controller/PhabricatorAuditAddCommentController.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/audit/mail/PhabricatorAuditMailReceiver.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditComment.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionCreateCommentConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility