Page MenuHomePhabricator
Differential D10129

Allow users to set view policies on files explicitly
ClosedPublic
Actions

Authored by epriestley on Aug 2 2014, 8:01 PM.
Tags
None
Referenced Files
F14369737: D10129.diff
Fri, Dec 20, 5:08 PM
Unknown Object (File)
Thu, Dec 12, 8:13 AM
Unknown Object (File)
Mon, Dec 2, 7:33 AM
Unknown Object (File)
Mon, Dec 2, 7:33 AM
Unknown Object (File)
Nov 4 2024, 11:35 AM
Unknown Object (File)
Nov 4 2024, 9:14 AM
Unknown Object (File)
Oct 21 2024, 12:23 AM
Unknown Object (File)
Oct 20 2024, 3:34 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4589: Fully implement granular file permissions and upload defaults
Commits
Restricted Diffusion Commit
rP4c04d4d01933: Allow users to set view policies on files explicitly
Summary

Ref T4589. Allow users to adjust visibility settings on files explicitly. This makes it easier to understand and manage upcoming changes in T4589.

Test Plan

Changed the view policy for a file several times.

Diff Detail

Repository
rP Phabricator
Branch
file7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2011
Build 2012: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24356.Aug 2 2014, 8:01 PM
epriestley retitled this revision from to Allow users to set view policies on files explicitly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4589: Fully implement granular file permissions and upload defaults.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 2 2014, 8:01 PM
Harbormaster completed remote builds in B2011: Diff 24356.Aug 2 2014, 8:02 PM
btrahan accepted this revision.Aug 2 2014, 9:09 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 2 2014, 9:09 PM
epriestley closed this revision.Aug 2 2014, 9:45 PM
epriestley updated this revision to Diff 24366.

Closed by commit rP4c04d4d01933 (authored by @epriestley).

Revision Contents
Changeset List

Diff 24356

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileEditController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileShortcutController.php

Loading...
View Options

src/applications/files/editor/PhabricatorFileEditor.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
Phabricator · Built by Phacility