Page MenuHomePhabricator
Differential D10130

Allow users to set an explicit visibility for manual file uploads at creation time
ClosedPublic
Actions

Authored by epriestley on Aug 2 2014, 8:06 PM.
Tags
None
Referenced Files
F19945607: D10130.diff
Thu, Apr 16, 7:16 PM
F19936351: D10130.diff
Sun, Apr 12, 8:18 AM
F19936350: D10130.diff
Sun, Apr 12, 8:18 AM
F19929378: D10130.diff
Wed, Apr 8, 4:07 PM
F19922991: D10130.id24367.diff
Mon, Apr 6, 11:57 PM
F19902082: D10130.id24357.diff
Mon, Mar 30, 3:08 PM
F19901449: D10130.id24357.diff
Mon, Mar 30, 10:22 AM
F19898548: D10130.diff
Sun, Mar 29, 1:41 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4589: Fully implement granular file permissions and upload defaults
Commits
Restricted Diffusion Commit
rP1f1828e0c00c: Allow users to set an explicit visibility for manual file uploads at creation…
Summary

Ref T4589. Depends on D10129. In addition to letting users change the visibility policy for files, also allow them to choose a policy explicitly when a file is uploaded.

Test Plan

Uploaded several files using the plain old uploader, saw appropriate visibility policies applied.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24357.Aug 2 2014, 8:06 PM
epriestley retitled this revision from to Allow users to set an explicit visibility for manual file uploads at creation time.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4589: Fully implement granular file permissions and upload defaults.
epriestley added a parent revision: D10129: Allow users to set view policies on files explicitly.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 2 2014, 8:06 PM
Harbormaster completed remote builds in B2012: Diff 24357.Aug 2 2014, 8:07 PM
epriestley updated this revision to Diff 24359.Aug 2 2014, 8:24 PM
  • Don't lose selection if users forgets to upload a file.
Harbormaster completed remote builds in B2014: Diff 24359.Aug 2 2014, 8:25 PM
btrahan accepted this revision.Aug 2 2014, 9:10 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 2 2014, 9:10 PM
epriestley closed this revision.Aug 2 2014, 9:46 PM
epriestley updated this revision to Diff 24367.

Closed by commit rP1f1828e0c00c (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
files/
controller/
30 lines

Diff 24367

View Options

src/applications/files/controller/PhabricatorFileUploadController.php

Loading...
Phabricator · Built by Phacility