Differential D10108

Workboards - fix broken links on pages accessed via tag
ClosedPublic
Actions

Authored by btrahan on Aug 1 2014, 5:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 31, 9:31 PM

	Unknown Object (File)
	Sat, Dec 21, 6:07 PM

	Unknown Object (File)
	Dec 11 2024, 5:04 AM

	Unknown Object (File)
	Dec 7 2024, 4:38 AM

	Unknown Object (File)
	Dec 3 2024, 10:56 AM

	Unknown Object (File)
	Nov 29 2024, 11:24 AM

	Unknown Object (File)
	Nov 25 2024, 6:17 AM

	Unknown Object (File)
	Nov 20 2024, 11:16 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T5763: 404 error when trying to add a column

Commits

Restricted Diffusion Commit
rP5ccc465798a5: Workboards - fix broken links on pages accessed via tag

Summary

$this->id wasn't being set in this case so just set it explicitly after we finish loading the project. Fixes T5763.

Test Plan

links were broken no longer!

Diff Detail

Repository

Branch

T5763

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/phragment/controller/PhragmentZIPController.php:54	PHL1	Unknown Symbol
Error	src/applications/phragment/controller/PhragmentZIPController.php:70	PHL1	Unknown Symbol
Error	src/applications/phragment/storage/PhragmentFragment.php:143	PHL1	Unknown Symbol

Unit

No Test Coverage

Build Status

Buildable 1982
Build 1983: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24309.Aug 1 2014, 5:52 PM

btrahan added a task: T5763: 404 error when trying to add a column.

btrahan retitled this revision from to Workboards - fix broken links on pages accessed via tag.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 1 2014, 5:52 PM

Harbormaster completed remote builds in B1982: Diff 24309.Aug 1 2014, 5:53 PM

epriestley accepted this revision.Aug 1 2014, 5:56 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 1 2014, 5:56 PM

Closed by commit rP5ccc465798a5 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

1 line

Diff 24309

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...