Page MenuHomePhabricator

Workboards - fix broken links on pages accessed via tag
ClosedPublic

Authored by btrahan on Aug 1 2014, 5:52 PM.
Tags
None
Referenced Files
F13885133: D10108.diff
Thu, Oct 3, 1:33 PM
Unknown Object (File)
Tue, Sep 10, 12:12 AM
Unknown Object (File)
Aug 31 2024, 4:44 PM
Unknown Object (File)
Aug 29 2024, 6:04 AM
Unknown Object (File)
Aug 19 2024, 7:27 PM
Unknown Object (File)
Aug 9 2024, 11:10 PM
Unknown Object (File)
Aug 5 2024, 4:16 PM
Unknown Object (File)
Aug 5 2024, 4:14 PM
Subscribers

Details

Summary

$this->id wasn't being set in this case so just set it explicitly after we finish loading the project. Fixes T5763.

Test Plan

links were broken no longer!

Diff Detail

Repository
rP Phabricator
Branch
T5763
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/phragment/controller/PhragmentZIPController.php:54PHL1Unknown Symbol
Errorsrc/applications/phragment/controller/PhragmentZIPController.php:70PHL1Unknown Symbol
Errorsrc/applications/phragment/storage/PhragmentFragment.php:143PHL1Unknown Symbol
Unit
No Test Coverage
Build Status
Buildable 1982
Build 1983: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Workboards - fix broken links on pages accessed via tag.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 5:56 PM
btrahan updated this revision to Diff 24310.

Closed by commit rP5ccc465798a5 (authored by @btrahan).