Differential D10076

Allow searching diffs by more status options
ClosedPublic
Actions

Authored by skyronic on Jul 30 2014, 1:44 PM.

Tags

None

Referenced Files

	F15517237: D10076.diff
	Sat, Apr 19, 1:05 AM

	F15483283: D10076.id24248.diff
	Wed, Apr 9, 11:20 AM

	F15481127: D10076.id24248.diff
	Tue, Apr 8, 6:22 PM

	F15479345: D10076.id24231.diff
	Tue, Apr 8, 6:29 AM

	F15476679: D10076.id.diff
	Mon, Apr 7, 8:34 AM

	F15474363: D10076.diff
	Sun, Apr 6, 7:46 AM

	F15470134: D10076.diff
	Fri, Apr 4, 8:20 PM

	F15423939: D10076.id24231.diff
	Mar 22 2025, 7:34 PM

Subscribers

Details

Reviewers

joshuaspence
epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5737: Allow searching for Accepted revisions

Commits

Restricted Diffusion Commit
rPbf10b7602bec: Allow searching diffs by more status options

Summary

This Fixes T5737. Apparently the functionality to search by different
statuses in differential was already there, but the options weren't
exposed in the frontend. I can't think of any reason why this should've
been the case, so I just added the other options.

Test Plan

Tested against some local diffs to match new query option.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

skyronic updated this revision to Diff 24231.Jul 30 2014, 1:44 PM

skyronic retitled this revision from to Allow searching diffs by more status options.

skyronic updated this object.

skyronic edited the test plan for this revision. (Show Details)

skyronic added reviewers: epriestley, joshuaspence.

skyronic added a task: T5737: Allow searching for Accepted revisions.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 30 2014, 1:44 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1934: Diff 24231.Jul 30 2014, 1:45 PM

This is sort of ick, but not worse than what we've already got. Thanks!

This revision is now accepted and ready to land.Jul 30 2014, 8:52 PM

Closed by commit rPbf10b7602bec (authored by Anirudh Sanjeev <anirudh@razorflow.com>, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionSearchEngine.php

11 lines

Diff 24248

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...