Page MenuHomePhabricator
Differential D10073

Prevent crash caused by empty array when rendering Pholio mocks
ClosedPublic
Actions

Authored by hach-que on Jul 30 2014, 1:10 AM.
Tags
None
Referenced Files
F14008738: D10073.diff
Wed, Oct 30, 5:58 AM
F14004420: D10073.id24228.diff
Sat, Oct 26, 8:22 PM
F14003789: D10073.id24228.diff
Sat, Oct 26, 10:47 AM
F14003788: D10073.id24226.diff
Sat, Oct 26, 10:47 AM
F14003787: D10073.id24254.diff
Sat, Oct 26, 10:47 AM
F13995853: D10073.id.diff
Wed, Oct 23, 4:05 PM
F13983990: D10073.id24228.diff
Sun, Oct 20, 10:09 AM
F13983415: D10073.id24254.diff
Sun, Oct 20, 6:18 AM
View All Files
Subscribers
epriestley
Korvin
rfergu

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPde40cf5ef7d6: Prevent crash caused by empty array when rendering Pholio mocks
Summary

This was causing a crash according to a conversation with @rfergu in IRC. The issue is that if $images_to_show is empty, then $image never gets set, and it attempts to call getID on a null / unset variable.

Test Plan

@rfergu confirmed this fixed the crash.

Diff Detail

Repository
rP Phabricator
Branch
pholio-crash
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1931
Build 1932: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 24226.Jul 30 2014, 1:10 AM
hach-que retitled this revision from to Prevent crash caused by variable usage outside foreach loop.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: Blessed Reviewers.
hach-que added a subscriber: rfergu.
Herald edited edge metadata. · View Herald TranscriptJul 30 2014, 1:10 AM
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1929: Diff 24226.Jul 30 2014, 1:11 AM
hach-que updated this revision to Diff 24227.Jul 30 2014, 1:47 AM
hach-que edited edge metadata.

Correct fix?

Harbormaster completed remote builds in B1930: Diff 24227.Jul 30 2014, 1:49 AM
hach-que retitled this revision from Prevent crash caused by variable usage outside foreach loop to Prevent crash caused by empty array when rendering Pholio mocks.Jul 30 2014, 1:49 AM
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)

@rfergu has confirmed that this fixes the crash.

hach-que edited the test plan for this revision. (Show Details)Jul 30 2014, 1:51 AM
hach-que added a reviewer: epriestley.
rfergu added a comment.Jul 30 2014, 1:52 AM

This works for me!

epriestley accepted this revision.Jul 30 2014, 3:21 AM
epriestley edited edge metadata.

This could just be if ($images_to_show), I think.

This revision is now accepted and ready to land.Jul 30 2014, 3:21 AM
hach-que updated this revision to Diff 24228.Jul 30 2014, 5:55 AM
hach-que edited edge metadata.

Changes requested

Herald added a subscriber: Korvin. · View Herald TranscriptJul 30 2014, 5:55 AM
Harbormaster completed remote builds in B1931: Diff 24228.Jul 30 2014, 5:56 AM
hach-que closed this revision.Jul 30 2014, 10:10 PM
hach-que updated this revision to Diff 24254.

Closed by commit rPde40cf5ef7d6 (authored by @hach-que).

Revision Contents
Changeset List

PathSize
src/
applications/
pholio/
view/
3 lines

Diff 24228

View Options

src/applications/pholio/view/PholioMockEmbedView.php

Loading...
Phabricator · Built by Phacility