Choose a better class name for PhutilMethodNotImplementedException
ClosedPublic
Actions

Authored by epriestley on Jul 23 2014, 3:17 PM.

Details

Reviewers

joshuaspence

Commits

rPHU4298b0da1573: Choose a better class name for PhutilMethodNotImplementedException

Summary

If you call $subclass->method() and the base class provides a default implementation which throws, you get BaseClass in the exception message.

Instead, produce Subclass in this case.

Test Plan

With Application subclasses missing getName() implementations, got more useful exceptions (e.g., "PhabricatorPasteApplication" is missing a method, not "PhabricatorApplication").

Diff Detail

Repository

rPHU libphutil

Branch

objname

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1863
Build 1864: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24105.Jul 23 2014, 3:17 PM

epriestley retitled this revision from to Choose a better class name for PhutilMethodNotImplementedException.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 23 2014, 3:17 PM

Harbormaster completed remote builds in B1863: Diff 24105.Jul 23 2014, 3:18 PM

joshuaspence accepted this revision.Jul 23 2014, 10:12 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Jul 23 2014, 10:12 PM

Closed by commit rPHU4298b0da1573 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

error/

PhutilMethodNotImplementedException.php

9 lines

Diff 24105

View Options

src/error/PhutilMethodNotImplementedException.php

Choose a better class name for PhutilMethodNotImplementedExceptionClosedPublicActions