Page MenuHomePhabricator
Differential D10027

Implement the `getName` method in `PhabricatorApplication` subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jul 23 2014, 12:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 12:30 AM
Unknown Object (File)
Fri, Dec 6, 5:31 PM
Unknown Object (File)
Tue, Dec 3, 10:30 AM
Unknown Object (File)
Sat, Nov 30, 7:59 AM
Unknown Object (File)
Mon, Nov 25, 2:43 PM
Unknown Object (File)
Mon, Nov 25, 7:56 AM
Unknown Object (File)
Sun, Nov 24, 5:31 PM
Unknown Object (File)
Sun, Nov 24, 12:58 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP0c8f487b0fa7: Implement the `getName` method in `PhabricatorApplication` subclasses
Summary

Provide an implementation for the getName method rather than automagically determining the application name.

Test Plan

Saw reasonable application names in the launcher.

Diff Detail

Repository
rP Phabricator
Branch
appname
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/base/PhabricatorApplication.php:31XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 1860
Build 1861: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 24096.Jul 23 2014, 12:53 PM
joshuaspence retitled this revision from to Implement the `getName` method in `PhabricatorApplication` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 23 2014, 12:53 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1858: Diff 24096.Jul 23 2014, 12:55 PM
joshuaspence updated this revision to Diff 24097.Jul 23 2014, 12:57 PM
joshuaspence edited edge metadata.
  • Forgot Maniphest
Harbormaster completed remote builds in B1859: Diff 24097.Jul 23 2014, 12:58 PM
joshuaspence updated this revision to Diff 24098.Jul 23 2014, 1:07 PM
  • Forget People application
  • Forgot Applications application
Harbormaster completed remote builds in B1860: Diff 24098.Jul 23 2014, 1:08 PM
epriestley accepted this revision.Jul 23 2014, 1:47 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2014, 1:47 PM
joshuaspence closed this revision.Jul 23 2014, 1:55 PM
joshuaspence updated this revision to Diff 24102.

Closed by commit rP0c8f487b0fa7 (authored by @joshuaspence).

joshuaspence mentioned this in D11119: Make the `PhabricatorApplication::getName()` method abstract.Jan 1 2015, 12:02 PM
joshuaspence mentioned this in rP22ee37e8b528: Make the `PhabricatorApplication::getName()` method abstract.Jan 1 2015, 11:07 PM

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
application/
4 lines
auth/
application/
4 lines
base/
16 lines
controller/
__tests__/
4 lines
calendar/
application/
4 lines
chatlog/
application/
4 lines
conduit/
application/
4 lines
config/
application/
4 lines
conpherence/
application/
4 lines
countdown/
application/
4 lines
differential/
application/
4 lines
diffusion/
application/
4 lines
diviner/
application/
4 lines
doorkeeper/
application/
4 lines
drydock/
application/
4 lines
feed/
application/
4 lines
files/
application/
4 lines
flag/
application/
4 lines
harbormaster/
application/
4 lines
help/
application/
4 lines
herald/
application/
4 lines
home/
application/
4 lines
legalpad/
application/
4 lines
macro/
application/
4 lines
maniphest/
application/
6 lines
meta/
application/
4 lines
people/
application/
4 lines
phrequent/
application/
4 lines
phriction/
application/
4 lines
policy/
application/
4 lines
ponder/
application/
4 lines
repository/
application/
4 lines
settings/
application/
4 lines
slowvote/
application/
6 lines
subscriptions/
application/
4 lines
support/
application/
4 lines
system/
application/
4 lines
transactions/
application/
4 lines
typeahead/
application/
4 lines
uiexample/
application/
4 lines
xhprof/
application/
4 lines

Diff 24098

View Options

src/applications/audit/application/PhabricatorAuditApplication.php

Loading...
View Options

src/applications/auth/application/PhabricatorAuthApplication.php

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/base/controller/__tests__/PhabricatorTestApplication.php

Loading...
View Options

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...
View Options

src/applications/chatlog/application/PhabricatorChatLogApplication.php

Loading...
View Options

src/applications/conduit/application/PhabricatorConduitApplication.php

Loading...
View Options

src/applications/config/application/PhabricatorConfigApplication.php

Loading...
View Options

src/applications/conpherence/application/PhabricatorConpherenceApplication.php

Loading...
View Options

src/applications/countdown/application/PhabricatorCountdownApplication.php

Loading...
View Options

src/applications/differential/application/PhabricatorDifferentialApplication.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diviner/application/PhabricatorDivinerApplication.php

Loading...
View Options

src/applications/doorkeeper/application/PhabricatorDoorkeeperApplication.php

Loading...
View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

Loading...
View Options

src/applications/feed/application/PhabricatorFeedApplication.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/flag/application/PhabricatorFlagsApplication.php

Loading...
View Options

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

Loading...
View Options

src/applications/help/application/PhabricatorHelpApplication.php

Loading...
View Options

src/applications/herald/application/PhabricatorHeraldApplication.php

Loading...
View Options

src/applications/home/application/PhabricatorHomeApplication.php

Loading...
View Options

src/applications/legalpad/application/PhabricatorLegalpadApplication.php

Loading...
View Options

src/applications/macro/application/PhabricatorMacroApplication.php

Loading...
View Options

src/applications/maniphest/application/PhabricatorManiphestApplication.php

Loading...
View Options

src/applications/meta/application/PhabricatorApplicationsApplication.php

Loading...
View Options

src/applications/people/application/PhabricatorPeopleApplication.php

Loading...
View Options

src/applications/phrequent/application/PhabricatorPhrequentApplication.php

Loading...
View Options

src/applications/phriction/application/PhabricatorPhrictionApplication.php

Loading...
View Options

src/applications/policy/application/PhabricatorPolicyApplication.php

Loading...
View Options

src/applications/ponder/application/PhabricatorPonderApplication.php

Loading...
View Options

src/applications/repository/application/PhabricatorRepositoriesApplication.php

Loading...
View Options

src/applications/settings/application/PhabricatorSettingsApplication.php

Loading...
View Options

src/applications/slowvote/application/PhabricatorSlowvoteApplication.php

Loading...
View Options

src/applications/subscriptions/application/PhabricatorSubscriptionsApplication.php

Loading...
View Options

src/applications/support/application/PhabricatorSupportApplication.php

Loading...
View Options

src/applications/system/application/PhabricatorSystemApplication.php

Loading...
View Options

src/applications/transactions/application/PhabricatorTransactionsApplication.php

Loading...
View Options

src/applications/typeahead/application/PhabricatorTypeaheadApplication.php

Loading...
View Options

src/applications/uiexample/application/PhabricatorUIExamplesApplication.php

Loading...
View Options

src/applications/xhprof/application/PhabricatorXHProfApplication.php

Loading...
Phabricator · Built by Phacility