Page MenuHomePhabricator

Fix rendering of project slugs in tokenizer UI
ClosedPublic

Authored by epriestley on Jul 21 2014, 1:09 PM.
Tags
None
Referenced Files
F14833117: D9996.id24024.diff
Thu, Jan 30, 8:36 AM
Unknown Object (File)
Thu, Jan 16, 3:18 AM
Unknown Object (File)
Wed, Jan 8, 6:19 AM
Unknown Object (File)
Dec 19 2024, 12:44 AM
Unknown Object (File)
Dec 8 2024, 6:35 PM
Unknown Object (File)
Dec 5 2024, 2:35 PM
Unknown Object (File)
Dec 1 2024, 6:31 AM
Unknown Object (File)
Nov 27 2024, 1:38 AM
Subscribers

Details

Summary

Fixes T5659. When building a token after a user selection, we currently use the value as the token text, but sometimes that's an internal name which doesn't make much sense to users. For projects, it is now "sluga slugb Proper Display Name". If available, use displayName instead.

Test Plan

Typed some projects into a tokenizer, got display names only.

Diff Detail

Repository
rP Phabricator
Branch
tokrender
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1804
Build 1805: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix rendering of project slugs in tokenizer UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad.
This revision is now accepted and ready to land.Jul 21 2014, 1:26 PM
epriestley updated this revision to Diff 24024.

Closed by commit rPaf214ecb6579 (authored by @epriestley).