Page MenuHomePhabricator
Differential D9972

Minor changes to various scripts
ClosedPublic
Actions

Authored by joshuaspence on Jul 18 2014, 12:00 AM.
Tags
None
Referenced Files
F15460533: D9972.diff
Mon, Mar 31, 11:39 PM
F15452787: D9972.id23962.diff
Sat, Mar 29, 7:15 AM
F15410730: D9972.id23962.diff
Wed, Mar 19, 8:18 AM
F15407309: D9972.id.diff
Tue, Mar 18, 4:50 PM
F15405730: D9972.id23966.diff
Tue, Mar 18, 11:50 AM
F15402179: D9972.diff
Mon, Mar 17, 9:08 PM
F15389124: D9972.id23966.diff
Sat, Mar 15, 4:55 AM
F15388383: D9972.diff
Sat, Mar 15, 3:45 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU6a24ff75f4fa: Minor changes to various scripts
Summary
  • Don't use type coercion unnecessarily
  • Minor formatting improvements
  • Better choices for variable names
Test Plan

Eye-ball it

Diff Detail

Repository
rPHU libphutil
Branch
minor
Lint
Lint Errors
SeverityLocationCodeMessage
Errorscripts/__init_script__.php:74XHP45PHP Compatibility
Advicescripts/sandpit/harden_directory.php:78XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 1758
Build 1759: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23962.Jul 18 2014, 12:00 AM
joshuaspence retitled this revision from to Minor changes to various scripts.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 18 2014, 12:00 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1758: Diff 23962.Jul 18 2014, 12:01 AM
epriestley accepted this revision.Jul 18 2014, 12:29 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 18 2014, 12:29 AM
joshuaspence closed this revision.Jul 18 2014, 12:31 AM
joshuaspence updated this revision to Diff 23966.

Closed by commit rPHU6a24ff75f4fa (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
scripts/
4 lines
example/
4 lines
3 lines
50 lines
sandpit/
25 lines
test/
4 lines
6 lines
6 lines
3 lines
4 lines
utils/
2 lines
3 lines
10 lines
src/
5 lines
support/
parser/
3 lines

Diff 23962

View Options

scripts/__init_script__.php

Loading...
View Options

scripts/example/subworkflow.php

Loading...
View Options

scripts/phutil_rebuild_map.php

Loading...
View Options

scripts/phutil_symbols.php

Loading...
View Options

scripts/sandpit/harden_directory.php

Loading...
View Options

scripts/test/deferred_log.php

Loading...
View Options

scripts/test/http.php

Loading...
View Options

scripts/test/paypal.php

Loading...
View Options

scripts/test/progress_bar.php

Loading...
View Options

scripts/test/service_profiler.php

Loading...
View Options

scripts/utils/directory_fixture.php

Loading...
View Options

scripts/utils/lock.php

Loading...
View Options

scripts/utils/utf8.php

Loading...
View Options

src/__phutil_library_init__.php

Loading...
View Options

support/parser/generate-type-parser.php

Loading...
Phabricator · Built by Phacility