Page MenuHomePhabricator
Differential D9968

Return a HTTP 500 instead of a HTTP 400 if an internal error occurs in the Aphlict server
ClosedPublic
Actions

Authored by joshuaspence on Jul 17 2014, 11:08 PM.
Tags
None
Referenced Files
F14319380: D9968.diff
Wed, Dec 18, 9:46 AM
Unknown Object (File)
Fri, Dec 13, 6:31 AM
Unknown Object (File)
Mon, Dec 9, 3:50 PM
Unknown Object (File)
Sun, Dec 8, 2:33 AM
Unknown Object (File)
Thu, Dec 5, 2:29 AM
Unknown Object (File)
Wed, Dec 4, 11:27 PM
Unknown Object (File)
Wed, Nov 27, 11:17 AM
Unknown Object (File)
Wed, Nov 20, 6:37 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5651: "400 Bad Request" errors from Aphlict server
Commits
Restricted Diffusion Commit
rPf2fee5a84e62: Return a HTTP 500 instead of a HTTP 400 if an internal error occurs in the…
Summary

Ref T5651. Only throw a HTTP 400 if the data is invalid (i.e. the request is bad). If something bad happens when trying to transmit the notification, throw a HTTP 500 instead.

Test Plan

Eye-ball it.

Diff Detail

Repository
rP Phabricator
Branch
aphlict500
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1753
Build 1754: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23951.Jul 17 2014, 11:08 PM
joshuaspence retitled this revision from to Return a HTTP 500 instead of a HTTP 400 if an internal error occurs in the Aphlict server.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5651: "400 Bad Request" errors from Aphlict server.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 17 2014, 11:08 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1753: Diff 23951.Jul 17 2014, 11:09 PM
epriestley accepted this revision.Jul 17 2014, 11:17 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 11:17 PM
joshuaspence closed this revision.Jul 17 2014, 11:20 PM
joshuaspence updated this revision to Diff 23953.

Closed by commit rPf2fee5a84e62 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
support/
aphlict/
server/
13 lines

Diff 23951

View Options

support/aphlict/server/aphlict_server.js

Loading...
Phabricator · Built by Phacility