Paths

Table of Contentst

Differential D9899

Share more code between tokenizers and global typeahead
ClosedPublic
Actions

Authored by epriestley on Jul 11 2014, 5:18 PM.

Tags

None

Referenced Files

	F14356879: D9899.diff
	Fri, Dec 20, 1:14 AM

	F14352969: D9899.id23923.diff
	Thu, Dec 19, 3:51 PM

	Unknown Object (File)
	Mon, Dec 16, 12:31 PM

	Unknown Object (File)
	Fri, Dec 13, 9:51 PM

	Unknown Object (File)
	Wed, Dec 11, 5:57 AM

	Unknown Object (File)
	Fri, Dec 6, 3:48 AM

	Unknown Object (File)
	Wed, Dec 4, 3:50 PM

	Unknown Object (File)
	Tue, Dec 3, 11:08 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T5306: Don't show archived projects in global typeahead by default
T4420: Modernize typeahead datasources

Commits

Restricted Diffusion Commit
rPa592b32ca4b9: Share more code between tokenizers and global typeahead

Summary

Ref T4420. Fixes T5306. Currently, the main menubar search has a lot of redundant/unshared code.

Move some common functions into JX.Prefab.whatever() and call them from the main search.

The major change here is that we apply the same "only show closed/disabled/archived objects if there are no matching open objects" logic, fixing T5306.

Test Plan

Used normal typeaheads.
Used global search.
Searched for a prefix shared by open and archived projects, didn't see the archived ones until the open ones were exhausted.

Diff Detail

Repository

Branch

tok11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1752
Build 1753: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23766.Jul 11 2014, 5:18 PM

epriestley retitled this revision from to Share more code between tokenizers and global typeahead.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T4420: Modernize typeahead datasources, T5306: Don't show archived projects in global typeahead by default.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 11 2014, 5:18 PM

Harbormaster completed remote builds in B1649: Diff 23766.Jul 11 2014, 5:20 PM

btrahan accepted this revision.Jul 17 2014, 10:31 PM

btrahan edited edge metadata.

btrahan added inline comments.

webroot/rsrc/js/core/Prefab.js
231	something for later / never, but i was surprised the object didn't have named fields (e.g. object.field) instead of being an array.

This revision is now accepted and ready to land.Jul 17 2014, 10:31 PM

epriestley added inline comments.Jul 17 2014, 10:36 PM

webroot/rsrc/js/core/Prefab.js
231	Ah, that's reasonable. I'll rename this to `fields` or something.

Rename object to fields.

Harbormaster completed remote builds in B1752: Diff 23923.Jul 17 2014, 10:38 PM

Closed by commit rPa592b32ca4b9 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

57 lines

src/

__phutil_library_map__.php

328 lines

webroot/

rsrc/

js/

core/

162 lines

behavior-search-typeahead.js

29 lines

Diff 23923

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

webroot/rsrc/js/core/Prefab.js

Loading...

webroot/rsrc/js/core/behavior-search-typeahead.js

Loading...