Page MenuHomePhabricator
Differential D9963

Fix HTTP 400 from notification server for JSON subscription objects
ClosedPublic
Actions

Authored by epriestley on Jul 17 2014, 2:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 7:03 AM
Unknown Object (File)
Tue, Dec 10, 6:48 PM
Unknown Object (File)
Sat, Dec 7, 11:44 AM
Unknown Object (File)
Fri, Nov 29, 12:16 PM
Unknown Object (File)
Tue, Nov 26, 3:50 PM
Unknown Object (File)
Mon, Nov 25, 8:18 PM
Unknown Object (File)
Mon, Nov 25, 8:17 PM
Unknown Object (File)
Sun, Nov 24, 8:32 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
Maniphest Tasks
T5651: "400 Bad Request" errors from Aphlict server
Commits
Restricted Diffusion Commit
rP6bf4ec97d563: Fix HTTP 400 from notification server for JSON subscription objects
Summary

Fixes T5651. Sometime we'll send an object to the notification server for subscribers, which it will choke on. Use array_values() to make sure we're sending an array.

Test Plan

With (object) instead, got a consistent error ("no .filter method on object"). With array_values(), no error.

Diff Detail

Repository
rP Phabricator
Branch
narray
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1741
Build 1742: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23905.Jul 17 2014, 2:19 PM
epriestley retitled this revision from to Possible fix for HTTP 400 from notification server.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
epriestley added a task: T5651: "400 Bad Request" errors from Aphlict server.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 17 2014, 2:19 PM
Harbormaster completed remote builds in B1741: Diff 23905.Jul 17 2014, 2:20 PM
epriestley updated this revision to Diff 23910.Jul 17 2014, 9:04 PM
  • Also log 400's.
  • Tested and confirmed it's actually the issue and works. Specifically, I used (object) to reliably reproduce the error:

    [Thu Jul 17 2014 14:02:23 GMT-0700 (PDT)] <127.0.0.1> Bad Request! TypeError: Object [object Object] has no method 'filter'
Harbormaster completed remote builds in B1745: Diff 23910.Jul 17 2014, 9:05 PM
joshuaspence accepted this revision.Jul 17 2014, 9:41 PM
joshuaspence edited edge metadata.

Yeah okay... this makes sense.

This revision is now accepted and ready to land.Jul 17 2014, 9:41 PM
joshuaspence added a comment.Jul 17 2014, 9:42 PM

(maybe clean up the diff title and summary before landing this)

epriestley retitled this revision from Possible fix for HTTP 400 from notification server to Fix HTTP 400 from notification server for JSON subscription objects.Jul 17 2014, 9:46 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.
epriestley closed this revision.Jul 17 2014, 9:48 PM
epriestley updated this revision to Diff 23917.

Closed by commit rP6bf4ec97d563 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
2 lines

Diff 23905

View Options

src/applications/feed/PhabricatorFeedStoryPublisher.php

Loading...
Phabricator · Built by Phacility