Page MenuHomePhabricator
Differential D9960

Minor change to `update_compat_info.php`
ClosedPublic
Actions

Authored by joshuaspence on Jul 17 2014, 12:25 PM.
Tags
None
Referenced Files
F13996321: D9960.id.diff
Wed, Oct 23, 8:06 PM
Unknown Object (File)
Sun, Oct 13, 7:51 PM
Unknown Object (File)
Sep 20 2024, 5:32 PM
Unknown Object (File)
Sep 19 2024, 11:45 PM
Unknown Object (File)
Sep 19 2024, 11:28 PM
Unknown Object (File)
Sep 19 2024, 8:54 PM
Unknown Object (File)
Sep 14 2024, 8:39 PM
Unknown Object (File)
Sep 2 2024, 4:50 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU39e3860b41bc: Minor change to `update_compat_info.php`
Summary

Replace file_put_contents with Filesystem::writeFile.

Test Plan

Ran ./scripts/update_compat_info.php.

Diff Detail

Repository
rPHU libphutil
Branch
fsapi
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/filesystem/Filesystem.php:556XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 1738
Build 1739: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23902.Jul 17 2014, 12:25 PM
joshuaspence retitled this revision from to Minor change to `update_compat_info.php`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 17 2014, 12:25 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1738: Diff 23902.Jul 17 2014, 12:27 PM
epriestley accepted this revision.Jul 17 2014, 2:13 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 2:13 PM
joshuaspence closed this revision.Jul 17 2014, 11:11 PM
joshuaspence updated this revision to Diff 23952.

Closed by commit rPHU39e3860b41bc (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
scripts/
example/
10 lines
2 lines
src/
filesystem/
7 lines

Diff 23902

View Options

scripts/example/calculator.php

Loading...
View Options

scripts/update_compat_info.php

Loading...
View Options

src/filesystem/Filesystem.php

Loading...
Phabricator · Built by Phacility