Paths

Table of Contentst

PHP compatibility fix
ClosedPublic
Actions

Authored by joshuaspence on Jul 17 2014, 9:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 14, 8:43 PM

	Unknown Object (File)
	Sat, Sep 14, 8:42 PM

	Unknown Object (File)
	Sat, Sep 14, 8:41 PM

	Unknown Object (File)
	Sat, Sep 14, 8:41 PM

	Unknown Object (File)
	Sun, Sep 8, 12:36 PM

	Unknown Object (File)
	Sat, Sep 7, 4:25 AM

	Unknown Object (File)
	Mon, Sep 2, 1:27 PM

	Unknown Object (File)
	Sun, Sep 1, 10:07 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU37aa6d36bf2d: PHP compatibility fix

Summary

Replace __DIR__ with dirname(__FILE__) because __DIR__ is only available in PHP 5.3.0.

Test Plan

If this differential works, then it seems that everything is okay.

Diff Detail

Repository

rPHU libphutil

Branch

__DIR__

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1735
Build 1736: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23896.Jul 17 2014, 9:13 AM

joshuaspence retitled this revision from to PHP compatibility fix.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 17 2014, 9:13 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1735: Diff 23896.Jul 17 2014, 9:14 AM

epriestley accepted this revision.Jul 17 2014, 11:39 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 17 2014, 11:39 AM

Closed by commit rPHU37aa6d36bf2d (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_init__.php

9 lines

Diff 23896

View Options

src/__phutil_library_init__.php

PHP compatibility fixClosedPublicActions