Paths

Table of Contentst

Differential D9925

Use `phutil_var_export` for `PhutilParserGenerator::formatAndIndent`
ClosedPublic
Actions

Authored by joshuaspence on Jul 14 2014, 7:29 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU48a04395363d: Use `phutil_var_export` for `PhutilParserGenerator::formatAndIndent`

Summary

phutil_var_export produces more readable output than var_export. Depends on D9923.

Test Plan

Eye-balled the PhutilTypeSpec code.

Diff Detail

Repository

rPHU libphutil

Branch

var_export3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1687
Build 1688: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23819.Jul 14 2014, 7:29 AM

joshuaspence retitled this revision from to Use `phutil_var_export` for `PhutilParserGenerator::formatAndIndent`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D9923: Add a `phutil_var_export` function.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 14 2014, 7:29 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1687: Diff 23819.Jul 14 2014, 7:30 AM

epriestley accepted this revision.Jul 14 2014, 2:17 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 14 2014, 2:17 PM

Closed by commit rPHU48a04395363d (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilParserGenerator.php

2 lines

PhutilTypeSpec.php

1213 lines

Diff 23819

View Options

src/parser/PhutilParserGenerator.php