Paths

Table of Contentst

Differential D9924

Use `phutil_var_export` in `PhutilLibraryMapBuilder`
ClosedPublic
Actions

Authored by joshuaspence on Jul 14 2014, 7:23 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU4b2053cded71: Use `phutil_var_export` in `PhutilLibraryMapBuilder`

Summary

phutil_var_export produces slightly-more-readable output than var_export. Depends on D9923.

Test Plan

Regenerated src/__phutil_library_map__.php.

Diff Detail

Repository

rPHU libphutil

Branch

var_export2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1686
Build 1687: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23818.Jul 14 2014, 7:23 AM

joshuaspence retitled this revision from to Use `phutil_var_export` in `PhutilLibraryMapBuilder`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D9923: Add a `phutil_var_export` function.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 14 2014, 7:23 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1686: Diff 23818.Jul 14 2014, 7:24 AM

epriestley accepted this revision.Jul 14 2014, 2:16 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 14 2014, 2:16 PM

Closed by commit rPHU4b2053cded71 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

15 lines

moduleutils/

PhutilLibraryMapBuilder.php

4 lines

Diff 23818

View Options

src/__phutil_library_map__.php