Page MenuHomePhabricator

Fix issue in Mercurial repos with duplicate branch heads
ClosedPublic

Authored by epriestley on Jul 13 2014, 12:28 PM.
Tags
None
Referenced Files
F14361505: D9918.diff
Fri, Dec 20, 11:31 AM
Unknown Object (File)
Fri, Nov 22, 3:12 AM
Unknown Object (File)
Nov 18 2024, 4:47 PM
Unknown Object (File)
Nov 18 2024, 6:05 AM
Unknown Object (File)
Nov 14 2024, 6:46 AM
Unknown Object (File)
Nov 9 2024, 11:46 PM
Unknown Object (File)
Nov 6 2024, 12:55 AM
Unknown Object (File)
Oct 22 2024, 10:46 PM
Subscribers

Details

Summary

Fixes T5613. A branch may have multiple heads in Mercurial, but executeOne() expects exactly one result.

Load them all instead. Equivalently, we could limit(1), but it's likely that we'll use the cursors in the future to reduce the number of VCS operations we do, so this is probably a little more along the lines where we're headed.

Test Plan

Poked around some repos.

Diff Detail

Repository
rP Phabricator
Branch
cursors
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1679
Build 1680: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix issue in Mercurial repos with duplicate branch heads.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: richardvanvelzen, chad.
This revision is now accepted and ready to land.Jul 13 2014, 1:49 PM
epriestley updated this revision to Diff 23808.

Closed by commit rP66a30ef97bbe (authored by @epriestley).