Page MenuHomePhabricator
Differential D9901

Support placeholder text in Herald
ClosedPublic
Actions

Authored by epriestley on Jul 11 2014, 5:37 PM.
Tags
None
Referenced Files
F13222956: D9901.diff
Sun, May 19, 4:08 AM
F13214676: D9901.id23768.diff
Fri, May 17, 12:20 PM
F13183114: D9901.id23768.diff
Fri, May 10, 6:58 AM
F13183113: D9901.id23947.diff
Fri, May 10, 6:58 AM
F13177415: D9901.diff
Wed, May 8, 7:42 PM
Unknown Object (File)
Fri, May 3, 9:42 AM
Unknown Object (File)
Tue, Apr 30, 5:14 PM
Unknown Object (File)
Mon, Apr 29, 2:55 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rP0e6756775c13: Support placeholder text in Herald
Summary

Ref T4420. We don't currently pass placeholder text properly, but should.

Test Plan

Saw placeholder text in Herald.

Diff Detail

Repository
rP Phabricator
Branch
tok13
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1651
Build 1652: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23768.Jul 11 2014, 5:37 PM
epriestley retitled this revision from to Support placeholder text in Herald.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4420: Modernize typeahead datasources.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 11 2014, 5:37 PM
Harbormaster completed remote builds in B1651: Diff 23768.Jul 11 2014, 5:38 PM
btrahan accepted this revision.Jul 17 2014, 10:33 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 10:33 PM
epriestley closed this revision.Jul 17 2014, 10:55 PM
epriestley updated this revision to Diff 23947.

Closed by commit rP0e6756775c13 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
applications/
herald/
controller/
7 lines
webroot/
rsrc/
js/
application/
herald/
3 lines

Diff 23768

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

Loading...
Phabricator · Built by Phacility