Differential D9872

After a file upload, take the user to the info page, not the view page
ClosedPublic
Actions

Authored by epriestley on Jul 10 2014, 1:34 PM.

Details

Reviewers

joshuaspence

Maniphest Tasks

T5588: Difficult to determine monogram after uploading a file

Commits

Restricted Diffusion Commit
rPd83bf5ea06d1: After a file upload, take the user to the info page, not the view page

Summary

Fixes T5588. If you upload an image, we currently take you to the image URL, but this makes it hard to figure out the monogram for use elsewhere.

Test Plan

Uploaded a file and was taken to the info page.

Diff Detail

Repository

rP Phabricator

Branch

finfouri

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1607
Build 1608: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23700.Jul 10 2014, 1:34 PM

epriestley retitled this revision from to After a file upload, take the user to the info page, not the view page.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

epriestley added a task: T5588: Difficult to determine monogram after uploading a file .

Herald added a subscriber: epriestley. · View Herald TranscriptJul 10 2014, 1:34 PM

Harbormaster completed remote builds in B1607: Diff 23700.Jul 10 2014, 1:35 PM

Thanks!

This revision is now accepted and ready to land.Jul 10 2014, 1:37 PM

Closed by commit rPd83bf5ea06d1 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

controller/

PhabricatorFileUploadController.php

2 lines

Diff 23700

View Options

src/applications/files/controller/PhabricatorFileUploadController.php

After a file upload, take the user to the info page, not the view pageClosedPublicActions