Decrease the priority of the `ArcanistPhutilLibraryLinter`
ClosedPublic
Actions

Authored by joshuaspence on Jul 9 2014, 10:00 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5577: `ArcanistPhutilLibraryLinter` causes `arc lint` to die if there is a PHP syntax error

Commits

rARC8975e3a4249c: Decrease the priority of the `ArcanistPhutilLibraryLinter`

Summary

Ref T5577. Decrease the priority of the ArcanistPhutilLibraryLinter such that it is lower than that of the ArcanistXHPASTLinter. There isn't any specific reason that we should do this, although it seems to generally be a reasonable idea.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23672.Jul 9 2014, 10:00 PM

joshuaspence retitled this revision from to Decrease the priority of the `ArcanistPhutilLibraryLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5577: `ArcanistPhutilLibraryLinter` causes `arc lint` to die if there is a PHP syntax error.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 9 2014, 10:00 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 9 2014, 10:00 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 9 2014, 10:00 PM

Harbormaster completed remote builds in B1595: Diff 23672.Jul 9 2014, 10:01 PM

Closed by commit rARC8975e3a4249c (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhutilLibraryLinter.php

4 lines

Diff 23675

View Options

src/lint/linter/ArcanistPhutilLibraryLinter.php

Decrease the priority of the `ArcanistPhutilLibraryLinter`ClosedPublicActions