Page MenuHomePhabricator
Differential D9819

Add an optional preamble to Legalpad documents
ClosedPublic
Actions

Authored by epriestley on Jul 4 2014, 3:26 PM.
Tags
None
Referenced Files
F13246319: D9819.id23566.diff
Thu, May 23, 9:22 AM
F13197244: D9819.diff
Sun, May 12, 11:56 PM
Unknown Object (File)
Fri, May 3, 8:36 AM
Unknown Object (File)
Mon, Apr 29, 5:27 AM
Unknown Object (File)
Wed, Apr 24, 10:50 PM
Unknown Object (File)
Apr 21 2024, 5:04 AM
Unknown Object (File)
Apr 21 2024, 5:04 AM
Unknown Object (File)
Apr 11 2024, 10:04 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T5532: Support corporate CLAs and signature exemptions
Commits
Restricted Diffusion Commit
rPeb28a7caeff5: Add an optional preamble to Legalpad documents
Summary

Fixes T5532. Allow documents to have a preamble in the header which can be used to explain who should sign a document and why.

Particularly, I plan to use this to navigate the corporate vs individual stuff more sensibly.

Test Plan

Screen_Shot_2014-07-04_at_8.23.45_AM.png (1×1 px, 157 KB)

Diff Detail

Repository
rP Phabricator
Branch
legalpremable
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1516
Build 1516: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23562.Jul 4 2014, 3:26 PM
epriestley retitled this revision from to Add an optional preamble to Legalpad documents.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5532: Support corporate CLAs and signature exemptions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 4 2014, 3:26 PM
epriestley added a comment.Jul 4 2014, 3:26 PM

I guess that is technically "corporate best friends forever".

Harbormaster completed remote builds in B1516: Diff 23562.Jul 4 2014, 3:27 PM
chad accepted this revision.Jul 4 2014, 4:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 4 2014, 4:05 PM
epriestley closed this revision.Jul 4 2014, 4:41 PM
epriestley updated this revision to Diff 23566.

Closed by commit rPeb28a7caeff5 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
sql/
autopatches/
2 lines
src/
applications/
legalpad/
constants/
1 line
controller/
16 lines
14 lines
editor/
9 lines
storage/
2 lines
9 lines
webroot/
rsrc/
css/
phui/
5 lines

Diff 23562

View Options

resources/celerity/map.php

Loading...
View Options

resources/sql/autopatches/20140704.legalpreamble.1.sql

Loading...
View Options

src/applications/legalpad/constants/LegalpadTransactionType.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentEditController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Loading...
View Options

src/applications/legalpad/storage/LegalpadDocument.php

Loading...
View Options

src/applications/legalpad/storage/LegalpadTransaction.php

Loading...
View Options

webroot/rsrc/css/phui/phui-fontkit.css

Loading...
Phabricator · Built by Phacility