Page MenuHomePhabricator
Differential D9799

Add "device ready" flag to standalone dialog pages
ClosedPublic
Actions

Authored by epriestley on Jul 2 2014, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 1:23 PM
Unknown Object (File)
Fri, Dec 20, 4:41 PM
Unknown Object (File)
Fri, Dec 20, 12:38 PM
Unknown Object (File)
Fri, Dec 20, 5:38 AM
Unknown Object (File)
Mon, Dec 16, 4:25 AM
Unknown Object (File)
Sun, Dec 15, 6:01 PM
Unknown Object (File)
Wed, Dec 4, 4:43 AM
Unknown Object (File)
Mon, Dec 2, 10:17 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
chad
Maniphest Tasks
T5541: "Entering High Security" page is not optimised for mobile
Commits
Restricted Diffusion Commit
rPc1f7b72dd867: Add "device ready" flag to standalone dialog pages
Summary

Fixes T5541. Standalone dialog pages, including the high-security auth page, should all work fine on mobile.

Test Plan

Screen_Shot_2014-07-02_at_1.24.03_PM.png (744×396 px, 150 KB)

Diff Detail

Repository
rP Phabricator
Branch
deviceready
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1487
Build 1487: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23518.Jul 2 2014, 8:25 PM
epriestley retitled this revision from to Add "device ready" flag to standalone dialog pages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad.
epriestley added a task: T5541: "Entering High Security" page is not optimised for mobile.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 2 2014, 8:25 PM
Harbormaster completed remote builds in B1487: Diff 23518.Jul 2 2014, 8:26 PM
joshuaspence accepted this revision.Jul 2 2014, 10:02 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jul 2 2014, 10:02 PM
epriestley closed this revision.Jul 3 2014, 1:49 AM
epriestley updated this revision to Diff 23527.

Closed by commit rPc1f7b72dd867 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
1 line

Diff 23518

View Options

src/applications/base/controller/PhabricatorController.php

Loading...
Phabricator · Built by Phacility