Page MenuHomePhabricator
Differential D9795

Allow Legalpad document managers to add signature exemptions
ClosedPublic
Actions

Authored by epriestley on Jul 2 2014, 3:46 AM.
Tags
None
Referenced Files
F14822664: D9795.id23508.diff
Tue, Jan 28, 9:11 AM
F14822108: D9795.diff
Tue, Jan 28, 7:31 AM
Unknown Object (File)
Tue, Jan 21, 9:13 AM
Unknown Object (File)
Fri, Jan 17, 3:49 PM
Unknown Object (File)
Sat, Jan 11, 4:56 PM
Unknown Object (File)
Sat, Jan 11, 4:56 PM
Unknown Object (File)
Sat, Jan 11, 4:54 PM
Unknown Object (File)
Mon, Dec 30, 10:54 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5532: Support corporate CLAs and signature exemptions
Commits
Restricted Diffusion Commit
rPb6ea2735d72c: Allow Legalpad document managers to add signature exemptions
Summary

Ref T5532. Allow document managers to add exemptions, which act like signatures but are tracked a little differently.

The primary use case for us is users who sign a corporate CLA and need a user-level exemption if they don't want to sign an individual CLA.

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Branch
legal3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1482
Build 1482: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23508.Jul 2 2014, 3:46 AM
epriestley retitled this revision from to Allow Legalpad document managers to add signature exemptions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T5532: Support corporate CLAs and signature exemptions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 2 2014, 3:46 AM
Harbormaster completed remote builds in B1482: Diff 23508.Jul 2 2014, 3:47 AM
epriestley added a comment.Jul 2 2014, 3:52 AM

New "Add exemption" button:

Screen_Shot_2014-07-01_at_8.37.46_PM.png (828×1 px, 112 KB)

Add exemption dialog:

Screen_Shot_2014-07-01_at_8.38.41_PM.png (828×1 px, 124 KB)

An exemption:

Screen_Shot_2014-07-01_at_8.38.53_PM.png (828×1 px, 120 KB)

Exemption detail:

Screen_Shot_2014-07-01_at_8.38.55_PM.png (828×1 px, 111 KB)

Altered signature message:

Screen_Shot_2014-07-01_at_8.42.06_PM.png (828×1 px, 94 KB)

chad accepted this revision.Jul 2 2014, 5:45 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 2 2014, 5:45 AM
epriestley closed this revision.Jul 2 2014, 11:59 AM
epriestley updated this revision to Diff 23513.

Closed by commit rPb6ea2735d72c (authored by @epriestley).

Revision Contents
Changeset List

Diff 23508

View Options

resources/sql/autopatches/20140701.legalexemption.1.sql

Loading...
View Options

resources/sql/autopatches/20140701.legalexemption.2.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/legalpad/application/PhabricatorApplicationLegalpad.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignatureAddController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignatureViewController.php

Loading...
View Options

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

Loading...
View Options

src/applications/legalpad/storage/LegalpadDocumentSignature.php

Loading...
View Options

src/docs/user/userguide/legalpad.diviner

Loading...
Phabricator · Built by Phacility