Page MenuHomePhabricator
Differential D9789

Enable unit tests for `ArcanistJscsLinterTestCase`
ClosedPublic
Actions

Authored by joshuaspence on Jun 30 2014, 10:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 19, 8:54 PM
Unknown Object (File)
Sat, Jan 18, 12:25 AM
Unknown Object (File)
Fri, Jan 17, 5:51 AM
Unknown Object (File)
Fri, Jan 17, 4:09 AM
Unknown Object (File)
Mon, Jan 13, 12:26 PM
Unknown Object (File)
Fri, Jan 3, 12:50 PM
Unknown Object (File)
Thu, Jan 2, 5:58 AM
Unknown Object (File)
Tue, Dec 31, 6:54 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCca5f05e62b09: Enable unit tests for `ArcanistJscsLinterTestCase`
Summary

https://github.com/mdevils/node-jscs/issues/444 has been resolved in commit 0de667bac2491ba04d930ff94e990965213ba36b, which means that jscs can be easily run on files with any extension.

NOTE: JSCS version 1.5.7 is required.
Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
jscs
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1474
Build 1474: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23496.Jun 30 2014, 10:59 PM
joshuaspence retitled this revision from to Enable unit tests for `ArcanistJscsLinterTestCase`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 30 2014, 10:59 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1474: Diff 23496.Jun 30 2014, 11:00 PM
epriestley accepted this revision.Jul 1 2014, 1:19 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2014, 1:19 PM
joshuaspence closed this revision.Jul 2 2014, 7:15 PM
joshuaspence updated this revision to Diff 23516.

Closed by commit rARCca5f05e62b09 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
__tests__/
6 lines
jscs/
4 lines

Diff 23496

View Options

src/lint/linter/__tests__/ArcanistJscsLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/jscs/curly-brace.lint-test

Loading...
Phabricator · Built by Phacility