Page MenuHomePhabricator
Differential D9787

Test cases should extend from `PhutilTestCase`
ClosedPublic
Actions

Authored by joshuaspence on Jun 30 2014, 8:02 PM.
Tags
None
Referenced Files
F15470581: D9787.id23494.diff
Fri, Apr 4, 11:31 PM
F15462100: D9787.diff
Tue, Apr 1, 12:49 PM
F15433423: D9787.id23492.diff
Mon, Mar 24, 11:05 PM
F15417823: D9787.id.diff
Thu, Mar 20, 6:52 PM
F15417086: D9787.id.diff
Thu, Mar 20, 3:12 PM
F15410263: D9787.id23492.diff
Wed, Mar 19, 6:58 AM
F15407715: D9787.id23494.diff
Tue, Mar 18, 7:07 PM
F15402577: D9787.diff
Mon, Mar 17, 11:04 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUb2903bea0271: Test cases should extend from `PhutilTestCase`
Summary

Currently, a few test cases in rPHU extend from ArcanistPhutilTestCase instead of PhutilTestCase.

Test Plan

This is a really minor change, but the unit tests still pass of course.

Diff Detail

Repository
rPHU libphutil
Branch
testcase-type
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1471
Build 1471: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23492.Jun 30 2014, 8:02 PM
joshuaspence retitled this revision from to Test cases should extend from `PhutilTestCase`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 30 2014, 8:02 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1471: Diff 23492.Jun 30 2014, 8:03 PM
epriestley accepted this revision.Jun 30 2014, 8:16 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2014, 8:16 PM
joshuaspence closed this revision.Jun 30 2014, 10:13 PM
joshuaspence updated this revision to Diff 23494.

Closed by commit rPHUb2903bea0271 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
cache/
__tests__/
2 lines
xsprintf/
__tests__/
2 lines
2 lines
2 lines

Diff 23492

View Options

src/cache/__tests__/PhutilKeyValueCacheTestCase.php

Loading...
View Options

src/xsprintf/__tests__/PhutilcsprintfTestCase.php

Loading...
View Options

src/xsprintf/__tests__/PhutilurisprintfTestCase.php

Loading...
View Options

src/xsprintf/__tests__/PhutilxsprintfTestCase.php

Loading...
Phabricator · Built by Phacility