Page MenuHomePhabricator
Differential D9749

Continue on bad daemon pid data
ClosedPublic
Actions

Authored by epriestley on Jun 26 2014, 10:17 PM.
Tags
None
Referenced Files
F14448899: D9749.id23410.diff
Thu, Dec 26, 6:53 PM
Unknown Object (File)
Wed, Dec 25, 3:23 PM
Unknown Object (File)
Sun, Dec 22, 12:56 AM
Unknown Object (File)
Fri, Dec 20, 10:34 PM
Unknown Object (File)
Mon, Dec 16, 7:37 AM
Unknown Object (File)
Sat, Dec 14, 6:09 PM
Unknown Object (File)
Tue, Dec 10, 9:34 PM
Unknown Object (File)
Sat, Dec 7, 2:11 PM
View All Files
Subscribers
epriestley
• galador

Details

Reviewers
joshuaspence
Commits
Restricted Diffusion Commit
rP950d81dac066: Continue on bad daemon pid data
Summary

The rest of this code works if we hand off array(), and fataling here, while more correct, is harder for users to get out of (they have to go manually remove files) and not obvious.

Test Plan

Corrupted pid file and ran phd stop.

Diff Detail

Repository
rP Phabricator
Branch
softparse
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1421
Build 1421: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23409.Jun 26 2014, 10:17 PM
epriestley retitled this revision from to Continue on bad daemon pid data.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 26 2014, 10:17 PM
joshuaspence accepted this revision.Jun 26 2014, 10:18 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jun 26 2014, 10:18 PM
Harbormaster completed remote builds in B1420: Diff 23409.Jun 26 2014, 10:18 PM
epriestley updated this revision to Diff 23410.Jun 26 2014, 10:21 PM
epriestley edited edge metadata.
  • Also recover from bad explicitArgv when running phd status.
epriestley closed this revision.Jun 26 2014, 10:22 PM
epriestley updated this revision to Diff 23411.

Closed by commit rP950d81dac066 (authored by @epriestley).

Harbormaster completed remote builds in B1421: Diff 23410.Jun 26 2014, 10:22 PM
• galador added a subscriber: • galador.Jun 26 2014, 10:27 PM

Revision Contents
Changeset List

PathSize
src/
applications/
daemon/
storage/
10 lines
infrastructure/
daemon/
control/
8 lines

Diff 23410

View Options

src/applications/daemon/storage/PhabricatorDaemonLog.php

Loading...
View Options

src/infrastructure/daemon/control/PhabricatorDaemonReference.php

Loading...
Phabricator · Built by Phacility