This further helps differentiate types/roles for projects.
Details
- Reviewers
chad - Commits
- Restricted Diffusion Commit
rPbe47f2141ab7: Allow projects icon color to be selected from several fabulous shades
Diff Detail
- Repository
- rP Phabricator
- Branch
- taglist2
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1408 Build 1408: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Joking aside, this went in a different direction than expected. I can see some benefit to assigning colors to Project Tags, but I'd likely want it to work everywhere, on the entire tag, not just the icon.
I also somewhat worry that the 'do whatever' per project might give installs too much freedom that's not really needed. Is there some means we could pre-select nice colors for specific roles of a project.
- Company/Client (Violet)
- Security (Red)
- Team (Green)
I'm hesitant to pre-assign meanings to colors, but coloring the entire tag looks great to me. I also want to put the icons in the list views, but the heaviness of the tag element is funky right now:
I'll just hold off on this stuff until you do a pass on them? (Or is that color stuff supported now? I think we only have bold/bright tags, not the light versions in your mock there?)
I think the icons/colors will be helpful, but definitely want to avoid turning the software into a garish mess.
Quick Thoughts:
- Restrict to Blue, Red, Violet, Green
- Provide 'hints' when they select colors, i.e. Red [Security|Unbreak]
- Color entire tag (new base border colors should work)
- Unsure if need to implement into ObjectItem. (Can mock it out)
This looks decent, though do we need to set the line-through on the disabled? Or is that coming from another css rule?