Page MenuHomePhabricator

Allow projects icon color to be selected from several fabulous shades
ClosedPublic

Authored by epriestley on Jun 24 2014, 6:53 PM.
Tags
None
Referenced Files
F14347994: D9710.diff
Thu, Dec 19, 4:40 AM
Unknown Object (File)
Tue, Dec 17, 7:16 AM
Unknown Object (File)
Sat, Dec 14, 12:58 PM
Unknown Object (File)
Wed, Dec 11, 5:12 AM
Unknown Object (File)
Tue, Dec 10, 9:46 AM
Unknown Object (File)
Sat, Dec 7, 1:11 AM
Unknown Object (File)
Fri, Dec 6, 7:19 PM
Unknown Object (File)
Wed, Dec 4, 8:54 AM
Subscribers

Details

Summary

This further helps differentiate types/roles for projects.

Test Plan

Screen_Shot_2014-06-24_at_11.50.55_AM.png (295×844 px, 44 KB)

Diff Detail

Repository
rP Phabricator
Branch
taglist2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1408
Build 1408: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Allow projects icon color to be selected from several fabulous shades.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Joking aside, this went in a different direction than expected. I can see some benefit to assigning colors to Project Tags, but I'd likely want it to work everywhere, on the entire tag, not just the icon.

tags.png (91×414 px, 6 KB)

I also somewhat worry that the 'do whatever' per project might give installs too much freedom that's not really needed. Is there some means we could pre-select nice colors for specific roles of a project.

  • Company/Client (Violet)
  • Security (Red)
  • Team (Green)

I'm hesitant to pre-assign meanings to colors, but coloring the entire tag looks great to me. I also want to put the icons in the list views, but the heaviness of the tag element is funky right now:

Screen_Shot_2014-06-24_at_1.43.16_PM.png (509×1 px, 105 KB)

I'll just hold off on this stuff until you do a pass on them? (Or is that color stuff supported now? I think we only have bold/bright tags, not the light versions in your mock there?)

I think the icons/colors will be helpful, but definitely want to avoid turning the software into a garish mess.

Quick Thoughts:

  • Restrict to Blue, Red, Violet, Green
  • Provide 'hints' when they select colors, i.e. Red [Security|Unbreak]
  • Color entire tag (new base border colors should work)
  • Unsure if need to implement into ObjectItem. (Can mock it out)
chad requested changes to this revision.Jun 26 2014, 3:12 AM
chad edited edge metadata.
__ __ _ \ \ / /__ _ _ _ __ _ __ ___ _____ _____ ___(_)_ __ \ V / _ \| | | | '__| | '_ ` _ \ / _ \ \ / / _ \ / __| | '__| | | (_) | |_| | | | | | | | | (_) \ V / __/_ \__ \ | |_ |_|\___/ \__,_|_| |_| |_| |_|\___/ \_/ \___( ) |___/_|_(_) |/
This revision now requires changes to proceed.Jun 26 2014, 3:12 AM
epriestley edited edge metadata.
  • Use new shades.

{F170319}

This looks decent, though do we need to set the line-through on the disabled? Or is that coming from another css rule?

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 26 2014, 4:54 AM

I added that explicitly -- I'll toss it.

epriestley edited edge metadata.
  • Don't strikethrough disabled (coloration should be enough of a cue).
epriestley updated this revision to Diff 23389.

Closed by commit rPbe47f2141ab7 (authored by @epriestley).

These may be too fruity still.