Page MenuHomePhabricator
Differential D9709

In standard property lists, render projects with tag UIs
ClosedPublic
Actions

Authored by epriestley on Jun 24 2014, 5:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:24 AM
Unknown Object (File)
Sun, Dec 15, 4:59 PM
Unknown Object (File)
Sun, Dec 15, 4:59 PM
Unknown Object (File)
Sun, Dec 15, 4:59 PM
Unknown Object (File)
Fri, Dec 13, 9:05 PM
Unknown Object (File)
Fri, Dec 6, 7:47 AM
Unknown Object (File)
Sat, Nov 30, 2:11 PM
Unknown Object (File)
Thu, Nov 21, 1:47 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T2628: Add project tags to Pholio, Ponder, Differential, and other applications
Commits
Restricted Diffusion Commit
rP38ae1191def9: In standard property lists, render projects with tag UIs
Summary

Ref T2628. There are a few UIs that need updates, but generally I want to show project icons everywhere that we show project names, to more strongly reinforce the ideas of projects being groups/tags/policies/etc.

Test Plan

See screenshot.

Diff Detail

Repository
rP Phabricator
Branch
taglist
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1363
Build 1363: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23316.Jun 24 2014, 5:24 PM
epriestley retitled this revision from to In standard property lists, render projects with tag UIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T2628: Add project tags to Pholio, Ponder, Differential, and other applications.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 24 2014, 5:24 PM
epriestley added a comment.Jun 24 2014, 5:24 PM

Screen_Shot_2014-06-24_at_10.21.08_AM.png (469×1 px, 96 KB)

Harbormaster completed remote builds in B1363: Diff 23316.Jun 24 2014, 5:25 PM
chad accepted this revision.Jun 24 2014, 5:40 PM
chad edited edge metadata.

bleh

This revision is now accepted and ready to land.Jun 24 2014, 5:40 PM
chad added a comment.Jun 24 2014, 5:40 PM

we are mixing blues and greys. this is horrible. i will re-write all of this.

chad added a comment.Jun 24 2014, 5:42 PM

so horrid

epriestley added a comment.Jun 24 2014, 5:59 PM

should I wait

I can wait

I am sorry

please do not be sad

epriestley added a comment.Jun 24 2014, 5:59 PM

In the next diff I am letting you change the color of the icons.

chad added a comment.Jun 24 2014, 6:03 PM

haha no i am being dramatic. go ahead and land, I'll tweak when I update.

epriestley closed this revision.Jun 26 2014, 5:01 AM
epriestley updated this revision to Diff 23388.

Closed by commit rP38ae1191def9 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
1 line
applications/
phid/
12 lines
project/
events/
14 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 23316

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
View Options

src/applications/project/events/PhabricatorProjectUIEventListener.php

Loading...
View Options

webroot/rsrc/css/phui/phui-tag-view.css

Loading...
Phabricator · Built by Phacility