Page MenuHomePhabricator

In standard property lists, render projects with tag UIs
ClosedPublic

Authored by epriestley on Jun 24 2014, 5:24 PM.

Details

Summary

Ref T2628. There are a few UIs that need updates, but generally I want to show project icons everywhere that we show project names, to more strongly reinforce the ideas of projects being groups/tags/policies/etc.

Test Plan

See screenshot.

Diff Detail

Repository
rP Phabricator
Branch
taglist
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 1363
Build 1363: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23316.Jun 24 2014, 5:24 PM
epriestley retitled this revision from to In standard property lists, render projects with tag UIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Jun 24 2014, 5:40 PM
chad edited edge metadata.

bleh

This revision is now accepted and ready to land.Jun 24 2014, 5:40 PM
chad added a comment.Jun 24 2014, 5:40 PM

we are mixing blues and greys. this is horrible. i will re-write all of this.

chad added a comment.Jun 24 2014, 5:42 PM

so horrid

should I wait

I can wait

I am sorry

please do not be sad

In the next diff I am letting you change the color of the icons.

chad added a comment.Jun 24 2014, 6:03 PM

haha no i am being dramatic. go ahead and land, I'll tweak when I update.

epriestley closed this revision.Jun 26 2014, 5:01 AM
epriestley updated this revision to Diff 23388.

Closed by commit rP38ae1191def9 (authored by @epriestley).